yourmumsdomain.com

PKing since 1893
It is currently Sat Mar 28, 2020 8:20 pm

All times are UTC




Post new topic Reply to topic  [ 9 posts ] 
Author Message
 Post subject: Mana Leech
PostPosted: Sat May 12, 2012 9:34 am 
Offline
Cardinal Chunder
User avatar

Joined: Fri Nov 19, 2004 11:23 pm
Posts: 1031
Calix,

Been looking at mana leech this morning with Joe, and it doesn't seem to be broken to me. With legendary necro/ss, I am leeching about 8-10 mana from a mob per wither from about 22-24 damage.

Perhaps you had insanely high skills set or something when you tested it?

For ref: GetDamageTypes in BaseWeapon calculates leeches for hits.
DoLeech in spellhelper for spells


Top
 Profile  
 
 Post subject: Re: Mana Leech
PostPosted: Sat May 12, 2012 1:55 pm 
Offline
MOTODEAMON

Joined: Sat Dec 27, 2003 10:05 am
Posts: 6109
k nice one, I'll have a look.

_________________
http://uded.net/bestronald.jpg


Top
 Profile  
 
 Post subject: Re: Mana Leech
PostPosted: Sat May 12, 2012 6:07 pm 
Offline
MOTODEAMON

Joined: Sat Dec 27, 2003 10:05 am
Posts: 6109
Tried this with normal skills and it's still the same, probably something to do with char being a GM. I'll try it on a normal char later.

_________________
http://uded.net/bestronald.jpg


Top
 Profile  
 
 Post subject: Re: Mana Leech
PostPosted: Sun May 13, 2012 9:20 am 
Offline
Cardinal Chunder
User avatar

Joined: Fri Nov 19, 2004 11:23 pm
Posts: 1031
Spellhelper.cs:

Replace
Code:
if ( context.Type == typeof( WraithFormSpell ) )
            {
               int wraithLeech = ( 5 + (int)( ( 15 * from.Skills.SpiritSpeak.Value ) / 100 ) ); // Wraith form gives 5-20% mana leech
               int manaLeech = AOS.Scale( damageGiven, wraithLeech );
               if ( manaLeech != 0 )
               {
                  from.Mana += manaLeech;
                  from.PlaySound( 0x44D );
               }
            }


With

Code:
if ( context.Type == typeof( WraithFormSpell ) )
            {
               int wraithLeech = ( 5 + (int)( ( 15 * from.Skills.SpiritSpeak.Value ) / 100 ) ); // Wraith form gives 5-20% mana leech
               int manaLeech = AOS.Scale( damageGiven, wraithLeech );
               if ( manaLeech != 0 )
               {
                  from.SendMessage( "You have hit for {1} and have leeched {0} mana", manaLeech, damageGiven );
                  from.Mana += manaLeech;
                  from.PlaySound( 0x44D );
               }
            }


Around line 984. You will now report dmg vs leech when using a spell in wraith form.


Top
 Profile  
 
 Post subject: Re: Mana Leech
PostPosted: Mon May 14, 2012 11:32 pm 
Offline
FISSURE OF WOE
User avatar

Joined: Fri Sep 30, 2005 7:54 am
Posts: 325
What is the current status of mana leech from weapon hits anyway? Ddid you lot change that?

_________________
Image
I-Cers about my joining I-C:
Clx: "risk", "what? dont", "I`ll object"
Future: "fucked up"
Villa: "dirty and unclean"
senj: "guildhopper"


Top
 Profile  
 
 Post subject: Re: Mana Leech
PostPosted: Mon May 14, 2012 11:51 pm 
Offline
MOTODEAMON

Joined: Sat Dec 27, 2003 10:05 am
Posts: 6109
Unedited. As per basic RunUO, so in theory as per OSI also.

_________________
http://uded.net/bestronald.jpg


Top
 Profile  
 
 Post subject: Re: Mana Leech
PostPosted: Tue May 15, 2012 6:17 pm 
Offline
FISSURE OF WOE
User avatar

Joined: Fri Sep 30, 2005 7:54 am
Posts: 325
Depends if base code is pre or post mana leech changes? I think we did some discussing on this a while back. plx2dig in forum and find out when next u at work.

_________________
Image
I-Cers about my joining I-C:
Clx: "risk", "what? dont", "I`ll object"
Future: "fucked up"
Villa: "dirty and unclean"
senj: "guildhopper"


Top
 Profile  
 
 Post subject: Re: Mana Leech
PostPosted: Fri May 18, 2012 2:55 am 
Offline
MOTODEAMON

Joined: Sat Dec 27, 2003 10:05 am
Posts: 6109
Will make time to test this today.

_________________
http://uded.net/bestronald.jpg


Top
 Profile  
 
 Post subject: Re: Mana Leech
PostPosted: Fri May 18, 2012 5:25 am 
Offline
MOTODEAMON

Joined: Sat Dec 27, 2003 10:05 am
Posts: 6109
Yeah seems ok. Must have been because char was GM.

_________________
http://uded.net/bestronald.jpg


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 9 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group